You are here: Foswiki>Tasks Web>Item9895 (26 Oct 2010, KennethLavrsen)Edit Attach

Item9895: ViewFileScript Unit tests fail on windows due to binmode issue in the tests.

pencil
Priority: Normal
Current State: Closed
Released In: 1.1.2
Target Release: patch
Applies To: Extension
Component: UnitTestContrib
Branches:
Reported By: GeorgeClark
Waiting For: Main.GeorgeClark
Last Change By: KennethLavrsen
ViewFileScriptTests fail due to several issues:

  • Regular expression used to strip headers was greedy for \r\n. If file content contained \r\n, then the entire contents were stripped.
  • The test attachments were created without binmode, so they contained \r\n instead of simple \n, causing more failures.

Also ViewFileScriptTests need to have some attachments with binary data that would be modified due to incorrect binmode on certain platforms. This probably won't fail on Linux, but will catch issues on Windows.

-- GeorgeClark - 26 Oct 2010

 

ItemTemplate edit

Summary ViewFileScript Unit tests fail on windows due to binmode issue in the tests.
ReportedBy GeorgeClark
Codebase 1.1.1, 1.1.0, trunk
SVN Range
AppliesTo Extension
Component UnitTestContrib
Priority Normal
CurrentState Closed
WaitingFor GeorgeClark
Checkins distro:6202d2c66bb3
TargetRelease patch
ReleasedIn 1.1.2
Edit  | Attach | Print version | History: r5 < r4 < r3 < r2 | Backlinks | View wiki text | Edit wiki text | More topic actions
Topic revision: r5 - 26 Oct 2010, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy