You are here: Foswiki>Tasks Web>Item11217 (30 Oct 2011, PaulHarvey)Edit Attach

Item11217: Can no longer add and keep comments for each rev of an attachment file. Duplicate Item11105

Priority: Normal
Current State: Duplicate
Released In: 1.1.4
Target Release: patch

Applies To: Engine
Component: Store
Branches:

Reported By: GordUrquhart
Waiting For: GordUrquhart
Last Change By: PaulHarvey

-- GordUrquhart - 29 Oct 2011

I have a need (and I'm sure others) for keeping the comments associated with each rev of an attachment in the RCS file for the attachment. This used to work in 1.1 but now in 1.3 it does not. It appears this was deliberate? The comment makes it all the way to Meta::attach where it gets dropped calling Store::saveAttachment. Actually dropped is the wrong term it gets replaced by the generic phrase "save attachment". Why?

-- GordUrquhart - 29 Oct 2011

This was an unfortunate oversight, fixed in Item11105 for Foswiki 1.1.4

We've added a unit test so this doesn't happen again.

-- PaulHarvey - 30 Oct 2011

ItemTemplate edit

Summary	Can no longer add and keep comments for each rev of an attachment file. Duplicate Item11105
ReportedBy	GordUrquhart
Codebase	1.1.3
SVN Range
AppliesTo	Engine
Component	Store
Priority	Normal
CurrentState	Duplicate
WaitingFor	GordUrquhart
Checkins
TargetRelease	patch
ReleasedIn	1.1.4