Item9747: Configure does not start complaining with a 500 error about "Use of uninitialized value" in Checker.pm

I wanted to test the translated strings in a live environment, so I checkout /branches/Release01x01/ from SVN, after doing a "cd core" and "perl -T pseudo-install.pl -A developer", chowning all the files to the Apache's user, setting up Apache, creating an admin user, restarting Apache, I point the browser to http://release01x01.myhost.net/bin/configure and I meet the following screen error:

Status: 500 Content-type: text/html
Software error:

Use of uninitialized value in numeric ne (!=) at /usr/local/www/data-dist/branches/Release01x01/core/lib/Foswiki/Configure/Checker.pm line 186.

For help, please send mail to the webmaster (webmaster@release01x01.myhost.net), giving this error message and the time and date of the error. 

Unless, I am doing something wrong that I can't figure out, I can't test Release01x01 because of that error.

Since release is supposed to be soon, I am marking this as urgent.

-- RaulFRodriguez - 25 Sep 2010

Wow, things are badly broken. It looks like configure is not picking up the defaut config.spec settings, so everything is uninitialized. Anything normally merged from Foswiki.spec is missing / uninitialized - even for existing configurations. Seems that only Release 1.1 is broken. Configure working fine on trunk.

-- GeorgeClark - 26 Sep 2010

git bisect says this is the culprit

226a680051bb774a1c6c16c2670149ad789cfe19 is the first bad commit
commit 226a680051bb774a1c6c16c2670149ad789cfe19
Author: AndreUlrich <AndreUlrich@0b4bb1d4-4e5a-0410-9cc4-b2b747904278>
Date:   Wed Sep 22 17:24:16 2010 +0000

    Item9526: bring in missing languages in configure. are there more places to set?
    
    git-svn-id: http://svn.foswiki.org/branches/Release01x01@9312 0b4bb1d4-4e5a-0410-9cc4-b2b747904278

:040000 040000 600231516043f4d0c03a6434bba7f28fa5d1d81d b64a2eb1984c9c75d2fccac4c68067853e3afcd3 M      core

-- GeorgeClark - 26 Sep 2010

We probably ought to better report that Foswiki.spec has had a compile error and was not usable. An added language code for pt-br was not quoted and caused a syntax error.

-$Foswiki::cfg{Languages}{pt-br}{Enabled} = 1;
+$Foswiki::cfg{Languages}{'pt-br'}{Enabled} = 1;

-- GeorgeClark - 26 Sep 2010

Load.pm could report corrupted config files back to the user. However this conflicts with changes to Engine/CGI.pm - which implemented code to do the same thing. Initial fix needs to be rethought. However the initial checkin that fixes the quoted language string resolves bug reported in this task. This task can be closed to not hold up Release 1.1, and the enhancements for better error reporting of configuration file errors handled in another task.

-- GeorgeClark - 26 Sep 2010

Thanks George for correcting this.

Will you open this other task? I think you know better how to describe this task

-- RaulFRodriguez - 27 Sep 2010

Item9753 opened for 1.1.1

-- GeorgeClark - 27 Sep 2010

Thanks !

-- RaulFRodriguez - 27 Sep 2010

Commenting is disabled while not logged in