Item9551: Modernize and enhance ImmediateNotifyPlugin

There are a number of issues in ImmediateNotifyPlugin

• Fails to set debug setting
• Uses several deprecated functions
• Uses calls to methods that are missing on Trunk
• Incorrectly gets UsersWeb name and treats the local variable as if it were a global
• Several typos
• Mail template uses the WIKILOGOURL to build incorrect links back to topics.
• regex for some Set statements are hardcoded to \t - tab character.
• Net::Jabber is deprecated by Net::XMPP
• Uses many globals, and does too much Init processing when unnecessary. Should lazy load the notifier methods.
• Passwords for notifier methods should be in LocalSite.cfg, and not visible in a topic.

-- GeorgeClark - 25 Aug 2010

Will, any thoughts. Babar pointed out that you had opened Item2590 to port this. I was trying to help someone get it working and by the time I finish I suspect I'll have rewritten it.

-- GeorgeClark - 29 Aug 2010

And one more question ... Any objections to my copying your IrcPlugin to be a notify method of ImmediateNotifyPlugin? (Or any comments on it's use?)

-- GeorgeClark - 29 Aug 2010

I also cannot get any output to data/debug.txt with

• Set DEBUG = 1

-- FrinkLabs - 24 May 2011

Have you installed the Extensions/Testing.ImmediateNotifyPlugin version? The version in Testing should be working. The version in the Extensions web has problems.

Note that the version in Testing has been changed to no longer read settings from the Extension topic. So you need to put things like DEBUG in the SitePreferences, prefixed with the Extension name. such as * Set IMMEDIATENOTIFYPLUGIN_DEBUG = 1 It appears I updated documentation after I had released the test version, so the docs are out of date. I got sidetracked on other work part way through. I'm reviewing a bit what's in SVN, I was doing some significant rewriting of some of the code after the test release, so I probably should not re-release without doing some more testing.

-- GeorgeClark - 25 May 2011

The version in Testing functions - thanks! To clarify, creating a WebImmediateNotify topic within a web and giving a fully-qualified WikiUser name on a parameter line will send immediate notifications of any changes to articles within that web. However you cannot specify per-article notifications within that topic; unlike MailerContrib this plugin attempts to parse the entire line as a WikiUser.

If I go to an article in a web without a WebImmediateNotify topi,c I can add within the body of the article a line that says

• Set IMMEDIATENOTIFY = WikiUser

that user will get notified if that topic is altered.

-- FrinkLabs - 25 May 2011

I tried out the testing version and could get debug info. I notice with the SMTP method I see the following entry:

| ... debug | - ImmediateNotifyPlugin::SMTP, failed to load: Can't locate Foswiki/Plugins/ImmediateNotifyPlugin/SMTP,.pm in @INC (@INC contains ... at... ImmediateNotifyPlugin.pm line 77

I can see an extra comma there in the value ImmediateNotifyPlugin/SMTP,.pm...

-- HughBlair - 02 Aug 2011

That issue is fixed in the svn version - I need to get another release built. Thanks for the feedback.

-- GeorgeClark - 03 Aug 2011

This is a never ending task - renamed it to better reflect what is happening. Working on unit tests, and will also merge in the Twitter and IRC notification extensions.

-- GeorgeClark - 01 Feb 2012

Commenting is disabled while not logged in