Item9538: Support.BestPracticeTip18 crashes trunk.foswiki.org

pencil
Priority: Urgent
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component: REVINFO
Branches:
Reported By: PaulHarvey
Waiting For: Main.CrawfordCurrie, Main.MichaelDaum
Last Change By: CrawfordCurrie
It's not even a very interesting topic, so I am wondering if there is something weird with RCS, time/date stamps, etc. on the server that might require shell access to debug this properly?

Possibly related: Item9482 which touched REVINFO recently, so marking this for Crawford & Michael's attention.

http://trunk.foswiki.org/Support.BestPracticeTip18 produces this backtrace:
Assertion (Attempt to reload 1 over version 2) failed!
 at /usr/home/trunk.foswiki.org/core/lib/Assert.pm line 80
   Assert::ASSERT(0, 'Attempt to reload 1 over version 2') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Meta.pm line 843
   Foswiki::Meta::loadVersion('Foswiki::Meta=HASH(0x1629c98)', 1) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Meta.pm line 298
   Foswiki::Meta::load('Foswiki::Meta=HASH(0x1629c98)', 1) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Render.pm line 1617
   Foswiki::Render::renderRevisionInfo('Foswiki::Render=HASH(0x25116a8)', 'Foswiki::Meta=HASH(0x1629c98)', 1, '$wikiusername') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Macros/REVINFO.pm line 30
   Foswiki::REVINFO('Foswiki=HASH(0xddd6d8)', 'Foswiki::Attrs=HASH(0x1629c88)', 'Foswiki::Meta=HASH(0x14fee78)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki.pm line 3016
   Foswiki::_expandMacroOnTopicRendering('Foswiki=HASH(0xddd6d8)', 'REVINFO', '"$wikiusername" topic="BestPracticeTip18" rev="1.1"', 'Foswiki::Meta=HASH(0x14fee78)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki.pm line 2906
   Foswiki::_processMacros('Foswiki=HASH(0xddd6d8)', '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN...', 'CODE(0xd4c5e8)', 'Foswiki::Meta=HASH(0x14fee78)', 16) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki.pm line 2703
   Foswiki::innerExpandMacros('Foswiki=HASH(0xddd6d8)', 'SCALAR(0xd4ce58)', 'Foswiki::Meta=HASH(0x14fee78)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki.pm line 3193
   Foswiki::expandMacros('Foswiki=HASH(0xddd6d8)', '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN...', 'Foswiki::Meta=HASH(0x14fee78)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Meta.pm line 2956
   Foswiki::Meta::expandMacros('Foswiki::Meta=HASH(0x14fee78)', '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN...') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI/View.pm line 399
   Foswiki::UI::View::_prepare('<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN...', 'Foswiki::Meta=HASH(0x14fee78)', 0) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI/View.pm line 359
   Foswiki::UI::View::view('Foswiki=HASH(0xddd6d8)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 310
   Foswiki::UI::__ANON__() called at /usr/local/lib/perl5/site_perl/5.8.8/Error.pm line 415
   eval {...} called at /usr/local/lib/perl5/site_perl/5.8.8/Error.pm line 407
   Error::subs::try('CODE(0xd8bc48)', 'HASH(0xddd3c8)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 429
   Foswiki::UI::_execute('Foswiki::Request=HASH(0xdbf568)', 'CODE(0xdbf128)', 'view', 1) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 277
   Foswiki::UI::handleRequest('Foswiki::Request=HASH(0xdbf568)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Engine/CGI.pm line 30
   Foswiki::Engine::CGI::run('Foswiki::Engine::CGI=HASH(0x901668)') called at /home/trunk.foswiki.org/core/bin/view line 24
 at /usr/home/trunk.foswiki.org/core/lib/Assert.pm line 80
   Assert::ASSERT(0, 'Attempt to reload 1 over version 2') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Meta.pm line 843
   Foswiki::Meta::loadVersion('Foswiki::Meta=HASH(0x1629c98)', 1) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Meta.pm line 298
   Foswiki::Meta::load('Foswiki::Meta=HASH(0x1629c98)', 1) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Render.pm line 1617
   Foswiki::Render::renderRevisionInfo('Foswiki::Render=HASH(0x25116a8)', 'Foswiki::Meta=HASH(0x1629c98)', 1, '$wikiusername') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Macros/REVINFO.pm line 30
   Foswiki::REVINFO('Foswiki=HASH(0xddd6d8)', 'Foswiki::Attrs=HASH(0x1629c88)', 'Foswiki::Meta=HASH(0x14fee78)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki.pm line 3016
   Foswiki::_expandMacroOnTopicRendering('Foswiki=HASH(0xddd6d8)', 'REVINFO', '"$wikiusername" topic="BestPracticeTip18" rev="1.1"', 'Foswiki::Meta=HASH(0x14fee78)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki.pm line 2906
   Foswiki::_processMacros('Foswiki=HASH(0xddd6d8)', '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN...', 'CODE(0xd4c5e8)', 'Foswiki::Meta=HASH(0x14fee78)', 16) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki.pm line 2703
   Foswiki::innerExpandMacros('Foswiki=HASH(0xddd6d8)', 'SCALAR(0xd4ce58)', 'Foswiki::Meta=HASH(0x14fee78)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki.pm line 3193
   Foswiki::expandMacros('Foswiki=HASH(0xddd6d8)', '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN...', 'Foswiki::Meta=HASH(0x14fee78)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Meta.pm line 2956
   Foswiki::Meta::expandMacros('Foswiki::Meta=HASH(0x14fee78)', '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN...') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI/View.pm line 399
   Foswiki::UI::View::_prepare('<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN...', 'Foswiki::Meta=HASH(0x14fee78)', 0) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI/View.pm line 359
   Foswiki::UI::View::view('Foswiki=HASH(0xddd6d8)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 310
   Foswiki::UI::__ANON__() called at /usr/local/lib/perl5/site_perl/5.8.8/Error.pm line 415
   eval {...} called at /usr/local/lib/perl5/site_perl/5.8.8/Error.pm line 407
   Error::subs::try('CODE(0xd8bc48)', 'HASH(0xddd3c8)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 429
   Foswiki::UI::_execute('Foswiki::Request=HASH(0xdbf568)', 'CODE(0xdbf128)', 'view', 1) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 277
   Foswiki::UI::handleRequest('Foswiki::Request=HASH(0xdbf568)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Engine/CGI.pm line 30
   Foswiki::Engine::CGI::run('Foswiki::Engine::CGI=HASH(0x901668)') called at /home/trunk.foswiki.org/core/bin/view line 24.

-- PaulHarvey - 24 Aug 2010

All of the other Best Practice Tip topics that aren't at revision 1 are crashing the same way. And reviewing anything other than the first version also causes the crash.

-- DavidPatterson - 24 Aug 2010

When the revision of the current topicObject doesn't equal the rrev param to renderRevisionInfo(), it must create a new Meta and load the wanted rev into it.

-- MichaelDaum - 24 Aug 2010

Seems to be something in the view template. default view template doesn't trigger the fault.

The view template is Support.BestPracticeTipsViewTemplate.

It seems the problem is with
%STARTSECTION{"revtest"}%
%REVINFO{"$wikiusername" topic="%INCLUDINGTOPIC%" rev="1.1"}% - %REVINFO{"$date"  rev="1.1"}%
%ENDSECTION{"revtest"}%

You can try it on this topic

-- PaulHarvey - 25 Aug 2010

It's just some stupid code in REVINFO that needs a lobotomy.

-- CrawfordCurrie - 25 Aug 2010
 
Topic revision: r7 - 25 Aug 2010, CrawfordCurrie
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy