You are here: Foswiki>Tasks Web>Item9463 (13 Aug 2010, ArthurClemens)Edit Attach

Item9463: Edit confirmation warning screen looks strange

pencil
Priority: Normal
Current State: Closed
Released In:
Target Release: n/a
Applies To: Engine
Component:
Branches:
Reported By: ArthurClemens
Waiting For:
Last Change By: ArthurClemens
It looks like the login screen but misses padding.

warning.png

Caused by strikeone_js:

    pcd: function() {
        // Use the browser getElementsByClassName implementation if available
        if (document.getElementsByClassName != null) {
            var js_ok = document.getElementsByClassName('s1js_available');
            for (i = 0; i < js_ok.length; i++)
                js_ok[i].style.display = 'inline';
        } else {
            // We *could* use the one in foswikilib.js, but that would mean
            // a dependency, plus it is less efficient than this.....
            var divs = document.getElementsByTagName('DIV');
            for (var i = 0; i < divs.length; i++) {
                if (/\bs1js_available\b/.test(divs[i].className))
                    divs[i].style.display = 'inline';
            }
        }
    }

Better to write

    js_ok[i].style.display = '';

    divs[i].style.display = '';

-- ArthurClemens - 12 Aug 2010

Fixed by CC in Item9442.

-- ArthurClemens - 13 Aug 2010

 

ItemTemplate edit

Summary Edit confirmation warning screen looks strange
ReportedBy ArthurClemens
Codebase trunk
SVN Range
AppliesTo Engine
Component
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:bbaa111321d6 distro:f82a9db3c64c
TargetRelease n/a
ReleasedIn
I Attachment Action Size Date Who Comment
warning.pngpng warning.png manage 41 K 12 Aug 2010 - 15:44 ArthurClemens  
Topic revision: r4 - 13 Aug 2010, ArthurClemens
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy