Item9433: Print view no longer works. It seems cover does not work

As noted by George on IRC the ?cover=print does not work at all

I tried skin=print and that works.

So it seems some code change as removed the cover feature. We need that back

Release blocker.

-- KennethLavrsen - 04 Aug 2010

> Modified: trunk/core/lib/Foswiki.pm
> ===================================================================
> --- trunk/core/lib/Foswiki.pm 2010-08-06 12:34:29 UTC (rev 8427)
> +++ trunk/core/lib/Foswiki.pm 2010-08-06 16:16:21 UTC (rev 8428)

> -    $dermis ||= $this->{prefs}->getPreference('SKIN');
> +    $skins = $this->{prefs}->getPreference('SKIN') unless defined $skins;

This changed behaviour: an empty skin url parameter now wipes out the skin path showing uggly default skin... breaks NatEditPlugin.

Me making it an unless $skin again.

-- MichaelDaum - 09 Aug 2010

Note that unless $skins will also catch * Set SKIN = 0 which is why I changed it. We are both wrong; the correct condition is

unless defined $skins && $skins ne ''

-- CrawfordCurrie - 09 Aug 2010

Decided to leave it, and doc it correctly instead.

-- CrawfordCurrie - 09 Aug 2010

Commenting is disabled while not logged in