Item9354: missing topic parameter and resulting bugs

Description

After the recent update of the wiki the HolidayListPlugin is broken. The main problem is that the parameter topic is no longer supported. I therefore removed this parameter and included the part of the topic where the list is. This leads to the next problem that now the WebLeftBar is now displayed on the right side instead of the left side. This was observed to happen when there are broken html comments or missing html tags such as </div>. Anyway, after disabling the HolidayList macro (by adding an !) the topic is displayed right (with the WebLeftBar on the left side).

-- HolgerHain - 19 Jul 2010

After some more checking I found the problem with the missdisplayed topic. In the topic is a form using the FORMFIELD macro. There the %STARTFORM{...}% is not rendered, resulting an a </div> and a </form> without the corresponding open tags <div> and <form>

This is a part of the html source with the %HOLIDAYLIST%

<div class="foswikiFormSteps">
<div class="foswikiFormStep">
<p />
<input type="hidden" name="comment_action" value="save" />

and the same part without (I just added a ! )

<div class="foswikiFormSteps">
<div class="foswikiFormStep">
<!--FormPlugin form start--><form method="post" action="http://intwiki.fzk.de/Indris/BoxSchedule#FormPluginNotification" enctype="multipart/form-data" name="box_shedule" id="box_shedule">
<div><input type="hidden" name="FP_actionurl" value="http://intwiki.fzk.de/cgi-bin/foswiki/save/Indris/BoxScheduleData" />
<input type="hidden" name="FP_name" value="box_shedule" />
<input type="hidden" name="comment_action" value="save" />

-- HolgerHain - 21 Jul 2010

The topic parameter is missing from the %defaults in Core.pm, so that it is erroneously considered to be an invalid parameter. You can fix it by adding topic to %defaults. I attach a simple patch that works for me but was not tested carefully so there might occur some sideeffects under certain circumstances.

• Core.pm.patch: quick and dirty patch for using topic parameter again

-- KerstinPuschke - 17 Nov 2010

Thanks Kerstin for your patch. It does solve a part of my problem. Now I can place my form in a topic and write to a different one. But this only works if I don't use the option redirectto. Using this option the redirectto-topic gets displayed (as it is supposed to) but there is nothing written to my topic defined by topic. This might be caused by an ordering problem as the topic gets probably redirected before using the topic option for writing.

I am just wondering why the topic parameter was removed from the default parameter set. I think this is gernerally a very useful parameter.

-- HolgerHain - 23 Nov 2010

STARTFORM is handled by FormPlugin.

topic parameter is fixed in plugin version 1.033.

-- ArthurClemens - 03 Jun 2011

Commenting is disabled while not logged in