Item9329: Edit links/buttons not correctly disabled

pencil
Priority: Urgent
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component:
Branches:
Reported By: KennethLavrsen
Waiting For:
Last Change By: CrawfordCurrie
Create a topic.

Create a revision of this topic so you have at least 2 revisions.

At the bottom bar click on rev 1. The Edit buttons are active. They should not be.

Click on rev 2. Edit buttons are disabled. They should be enabled because we are at revision 2.

The buttons must be enabled of the revision is not given in the URL or the revision is same as the current.

This worked fine in 1.0.9

Release blocker as it is direct user interface.

-- KennethLavrsen - 15 Jul 2010

It was Crawford that broke it in http://trac.foswiki.org/changeset/7327. So I set it Waiting For Crawford.

-- KennethLavrsen - 15 Jul 2010

Very strange.

  1. Create r1 - r1 is editable
  2. Create r2 - r2 is editable, as is r1
  3. Create r3 - r3 is not editable, r2 is not editable, r1 is editable
  4. Create r4 - r4 is editable, r3 and r2 are not editable, r1 is editable
  5. Create r5 - r5 is editable, r4-r2 are not editable, r1 is editable

Hmmm. Confirmed.

-- CrawfordCurrie - 16 Jul 2010
(08:11:50) Lavr: CDot. In UI/View.pm there is a line     if ( $showRev && $revIt->hasNext() && $showRev != $revIt->next() ) {
(08:11:50) Lavr:         $session->enterContext('inactive');
(08:12:15) Lavr: I did a little tracing. The  $revIt->hasNext() returns nothing when rev is 1

ItemTemplate edit

Summary Edit links/buttons not correctly disabled
ReportedBy KennethLavrsen
Codebase trunk
SVN Range
AppliesTo Engine
Component
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:88f1aed0d6f2
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r5 - 16 Jul 2010, CrawfordCurrie
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy