Item9147: Generating multiple checked="checked" attributes rendering System.DataForms

pencil
Priority: Low
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component: DataForms
Branches:
Reported By: PaulHarvey
Waiting For: Main.PaulHarvey
Last Change By: KennethLavrsen
New unit test & proper fix to checkbox problems found in Item9007:
  • Original fix killed DataForms functionality
  • But there were no additional unit tests failures, and there should have been
  • Still haven't got a fix that cleans up XHTML validation when rendering preselected checkboxes from DataForms

-- PaulHarvey - 12 Jun 2010

I wrote a test; but I just couldn't figure out how to get the faulty fix that Michael reverted Item9007 to cause it to fail. It certainly failed from a real web browser, however; and it does fail if you mangle Foswiki::Form::Checkbox in other ways.

So, I don't feel there's much more I can do - the tests are better than nothing, one day it would be nice to have Selenium based tests :/

-- PaulHarvey - 14 Jun 2010
 
Topic revision: r13 - 04 Oct 2010, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy