Item8961: ASSERTION in rdiff

I turned off HistoryPlugin, and then went to the older rdiff -

http://localhost/trunk/bin/rdiff/Sandbox/TestTopic0?type=history

begets me

Assertion (1 == 10) failed!
 at /home/sven/src/foswiki/trunk/core/lib/Assert.pm line 65
   Assert::ASSERT('', '1 == 10') called at /home/sven/src/foswiki/trunk/core/lib/Foswiki/UI/RDiff.pm line 534
   Foswiki::UI::RDiff::diff('Foswiki=HASH(0x29b47d0)') called at /home/sven/src/foswiki/trunk/core/lib/Foswiki/UI.pm line 303
   Foswiki::UI::__ANON__() called at /usr/local/share/perl/5.10.1/Error.pm line 415
   eval {...} called at /usr/local/share/perl/5.10.1/Error.pm line 407
   Error::subs::try('CODE(0x212ef58)', 'HASH(0x29b4398)') called at /home/sven/src/foswiki/trunk/core/lib/Foswiki/UI.pm line 410
   Foswiki::UI::_execute('Foswiki::Request=HASH(0x2155080)', 'CODE(0x2994b50)', 'diff', 1) called at /home/sven/src/foswiki/trunk/core/lib/Foswiki/UI.pm line 270
   Foswiki::UI::handleRequest('Foswiki::Request=HASH(0x2155080)') called at /home/sven/src/foswiki/trunk/core/lib/Foswiki/Engine/CGI.pm line 29
   Foswiki::Engine::CGI::run('Foswiki::Engine::CGI=HASH(0x2468788)') called at /home/sven/src/foswiki/trunk/core/bin/rdiff line 45
 at /home/sven/src/foswiki/trunk/core/lib/Assert.pm line 65
   Assert::ASSERT('', '1 == 10') called at /home/sven/src/foswiki/trunk/core/lib/Foswiki/UI/RDiff.pm line 534
   Foswiki::UI::RDiff::diff('Foswiki=HASH(0x29b47d0)') called at /home/sven/src/foswiki/trunk/core/lib/Foswiki/UI.pm line 303
   Foswiki::UI::__ANON__() called at /usr/local/share/perl/5.10.1/Error.pm line 415
   eval {...} called at /usr/local/share/perl/5.10.1/Error.pm line 407
   Error::subs::try('CODE(0x212ef58)', 'HASH(0x29b4398)') called at /home/sven/src/foswiki/trunk/core/lib/Foswiki/UI.pm line 410
   Foswiki::UI::_execute('Foswiki::Request=HASH(0x2155080)', 'CODE(0x2994b50)', 'diff', 1) called at /home/sven/src/foswiki/trunk/core/lib/Foswiki/UI.pm line 270
   Foswiki::UI::handleRequest('Foswiki::Request=HASH(0x2155080)') called at /home/sven/src/foswiki/trunk/core/lib/Foswiki/Engine/CGI.pm line 29
   Foswiki::Engine::CGI::run('Foswiki::Engine::CGI=HASH(0x2468788)') called at /home/sven/src/foswiki/trunk/core/bin/rdiff line 45.

-- SvenDowideit - 30 Apr 2010

I get the same here on t.f.o if I turn on ASSERTs

see http://trunk.foswiki.org/bin/rdiff/Tasks/Item8953?type=history

-- SvenDowideit - 30 Apr 2010

This may have happened because the topic at that particular rev contained a TOPICINFO with a version= that was not the version that was actually loaded.

-- CrawfordCurrie - 03 May 2010

With the recent changes to version management this shouldn't happen any more.

Please try your testcase, and if it's OK close this. Note that RDiff really needs rewriting to support non-sequential versioning.

-- CrawfordCurrie - 05 May 2010

yup, looks good.

-- SvenDowideit - 10 May 2010

Commenting is disabled while not logged in