You are here: Foswiki>Tasks Web>Item896 (01 Sep 2009, SvenDowideit)Edit Attach

Item896: Move the Password module to the right place

pencil
Priority: Low
Current State: Closed
Released In:
Target Release:
Applies To: Engine
Component: CodeRefactoring
Branches:
Reported By: CrawfordCurrie
Waiting For:
Last Change By: SvenDowideit
At present the Password.pm module is a base class, but doesn't observe the same pattern as other base classes viz it is in the Users directory.

This is mainly inertia, but also the fact that any custom password managers should be here, and are selected from this dir by configure.

Should really
  • Move the Foswiki/Users/Password.pm module to Foswiki/PasswordManager.pm
  • And move HtpasswdUser etc to Foswiki/PasswordManager/
  • And rename 'Users/' to 'UserMappingManager/'

-- CC

actually, I'm not 100% sure i agree. Foswiki::Users::Password i think is not accessed directly by Foswiki - I think i made all the calls to it go via Users.pm and the Mappers - as its not actually applicable, nor needed for many user mappers.

if I'm right, then the Passwd.pm is in the right place - its like the Store Handlers oddity.

and renaming Users really isn't worth it imo, cos it'll cause alot of people to need to re-re-re do their work.

-- SvenDowideit - 01 May 2009

closing..

-- SvenDowideit - 01 Sep 2009

ItemTemplate edit

Summary Move the Password module to the right place
ReportedBy CrawfordCurrie
Codebase
SVN Range SVN 2224: Foswiki-1.0.0, Fri, 23 Jan 2009, build 2135
AppliesTo Engine
Component CodeRefactoring
Priority Low
CurrentState Closed
WaitingFor
Checkins
ReleasedIn
Topic revision: r4 - 01 Sep 2009, SvenDowideit
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy