Item8943: META data lost

There've been a couple of occasions that META data was lost after changing the topic. Actions have been related to changing attachment information.

Here's the diff before and after hiding Logo2.gif:

--- before.txt 2010-04-22 12:17:57.000000000 +0200
+++ afterr.txt        2010-04-22 12:17:24.000000000 +0200
@@ -1,4 +1,4 @@
-%META:TOPICINFO{author="micha" comment="reprev" date="1271930907" format="1.1" reprev="1.5" rev="5" version="1.5"}%
+%META:TOPICINFO{author="micha" comment="reprev" date="1271931444" format="1.1" reprev="1.5" rev="5" version="1.5"}%

-%META:FILEATTACHMENT{name="Logo2.gif" attachment="Logo2.gif" attr="" author="micha" comment="" date="1246984334" size="8079" version="1"}%
+%META:FILEATTACHMENT{name="Logo2.gif" attachment="Logo2.gif" attr="h" author="micha" comment="" date="1246984334" size="8079" version="1"}%
-%META:FILEATTACHMENT{name="Logo.gif" attr="h" comment="1"}%

Logo.gif was removed plus it didn't have all attrs.

There have been a lot more attachments on this topic before. A different attach operation whiped them out. They are still in the pub dir.

Restored old topic, tried again, happend again. Here's the second diff:

--- before.txt 2010-04-22 12:29:02.000000000 +0200
+++ after.txt        2010-04-22 12:29:35.000000000 +0200
@@ -1,4 +1,4 @@
-%META:TOPICINFO{author="micha" comment="reprev" date="1271931444" format="1.1" reprev="1.5" rev="5" version="1.5"}%
+%META:TOPICINFO{author="micha" comment="reprev" date="1271932175" format="1.1" reprev="1.5" rev="5" version="1.5"}%

-%META:FILEATTACHMENT{name="Logo2.gif" attachment="Logo2.gif" attr="h" author="micha" comment="" date="1246984334" size="8079" version="1"}%
+%META:FILEATTACHMENT{name="Logo2.gif" attachment="Logo2.gif" attr="" author="micha" comment="" date="1246984334" size="8079" version="1"}%
 %META:FILEATTACHMENT{name="Bild.gif" attachment="Bild.gif" attr="" author="micha" comment="" date="1246984334" size="122799" version="1"}%
-%META:FILEATTACHMENT{name="Logo2.xcf" attachment="Logo2.xcf" attr="" author="micha" comment="" date="1246988866" path="Logo2.xcf" size="70826" version="1"}%
-%META:FILEATTACHMENT{name="Logo.png" attachment="Logo.png" attr="" author="micha" comment="" date="1246988886" path="Logo.png" size="19930" version="1"}%
-%META:FILEATTACHMENT{name="Logo-weiss.gif" attachment="Logo-weiss.gif" attr="" author="micha" comment="" date="1247042927" path="Logo-weiss.gif" size="11188" version="1"}%
-%META:FILEATTACHMENT{name="Logo-transparent.gif" attachment="Logo-transparent.gif" attr="" author="micha" comment="" date="1247042939" path="Logo-transparent.gif" size="5002" version="1"}%
-%META:FILEATTACHMENT{name="logo.gif" attachment="logo.gif" attr="" author="micha" comment="" date="1247042952" path="logo.gif" size="8723" version="1"}%

-- MichaelDaum - 22 Apr 2010

This is related to our previous investigations. Foswiki::Meta::attach calls reload() on the topic, but if the currently loaded rev is not the latest rev, it can end up wiping on meta that was added since the rev that is loaded. The call should be reload(0). it worked before through sheer luck.

Michael, can you check it's OK for you now?

-- CrawfordCurrie - 23 Apr 2010

Will do. It may need some time testing on day-to-day use til errors like these show up or don't anymore.

-- MichaelDaum - 23 Apr 2010

I am using foswiki/trunk extensively everyday and have never seen this error anymore.

-- MichaelDaum - 25 Jun 2010

Commenting is disabled while not logged in