You are here: Foswiki>Tasks Web>Item8938 (13 Mar 2011, GeorgeClark)Edit Attach

Item8938: bogus handleKeyDown event handler in edit.pattern.tmpl

pencil
Priority: Normal
Current State: No Action Required
Released In: 1.1.3
Target Release: patch
Applies To: Extension
Component: PatternSkin
Branches:
Reported By: PaulHarvey
Waiting For:
Last Change By: GeorgeClark
Hi Arthur, can we kill this handleKeyDown event handler? There's no code for it and it makes the JS error logs quite noisy

Index: trunk/PatternSkin/templates/edit.pattern.tmpl
===================================================================
--- trunk/PatternSkin/templates/edit.pattern.tmpl   (revision 7231)
+++ trunk/PatternSkin/templates/edit.pattern.tmpl   (working copy)
@@ -61,7 +61,7 @@
 %TMPL:DEF{"pagehelp"}%%TWISTYTOGGLE{id="edithelp" mode="div" remember="on" noscript="hide"}%<div class="foswikiHelp">%TMPL:P{"help"}%%TMPL:P{"actionbuttons_help"}%</div>%ENDTWISTYTOGGLE%%TMPL:END%
 
 
-%TMPL:DEF{"textarea"}%%TMPL:P{"forceie8compatibilitymode"}%<div class="patternEditTopic"><textarea class="foswikiTextarea foswikiEditboxStyleProportional foswikiWysiwygEdit" id="topic" name="text" rows="%EDITBOXHEIGHT%" cols="%EDITBOXWIDTH%" style='%EDITBOXSTYLE%' onkeydown='handleKeyDown(event)'>%TEXT%</textarea>%TMPL:P{"sig_textareabuttons"}%</div><!--/patternEditTopic-->%TMPL:END%
+%TMPL:DEF{"textarea"}%%TMPL:P{"forceie8compatibilitymode"}%<div class="patternEditTopic"><textarea class="foswikiTextarea foswikiEditboxStyleProportional foswikiWysiwygEdit" id="topic" name="text" rows="%EDITBOXHEIGHT%" cols="%EDITBOXWIDTH%" style='%EDITBOXSTYLE%'>%TEXT%</textarea>%TMPL:P{"sig_textareabuttons"}%</div><!--/patternEditTopic-->%TMPL:END%
 
 
 %TMPL:DEF{"sig_textareabuttons"}%<div class="patternSigLine">%IF{"not context TinyMCEPluginEnabled or $nowysiwyg='1' or $NOWYSIWYG='1'" then='%TMPL:P{"textareabuttons"}%'}%%TMPL:P{"sig"}%<br class="foswikiClear" /></div><!-- /patternSigLine-->%TMPL:END%

-- PaulHarvey - 21 Apr 2010

Yes, it has been there for legacy reasons (and apparently not supported). Instead we should have a warning like TinyMCE to warn if you navigate away from the page.

-- ArthurClemens - 21 Apr 2010

Changing this to no action required. The code in question is not in the current pattern skin release.

-- GeorgeClark - 13 Mar 2011
 

ItemTemplate edit

Summary bogus handleKeyDown event handler in edit.pattern.tmpl
ReportedBy PaulHarvey
Codebase trunk
SVN Range
AppliesTo Extension
Component PatternSkin
Priority Normal
CurrentState No Action Required
WaitingFor
Checkins
TargetRelease patch
ReleasedIn 1.1.3
Topic revision: r3 - 13 Mar 2011, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy