Item8865: rdiff DIFFRENDERSTYLE does not work as expected
Priority: Normal
Current State: Closed
Released In: 1.0.10
Target Release: patch
Applies To: Engine
Component: rdiff
Branches:
According to
the rdiff documentation
Parameter |
Description |
Default |
render |
the rendering style {sequential, sidebyside, raw, debug} |
DIFFRENDERSTYLE, sequential |
I would expect that setting
* Set DIFFRENDERSTYLE = sidebyside
would affect the initial radio button setting in the "Compare revisions" section under "More topic actions".
It does not affect that.
It should.
Possible fix
Change
oopsmorecompare.pattern.tmpl
so one of the comparison choice radio buttons is checked only in response to
DIFFRENDERSTYLE
.
For each
<input type="radio"
check the value of
DIFFRENDERSTYLE
e.g.
<input type="radio" name="render" id="sequential" value="sequential" %IF{ "$ DIFFRENDERSTYLE='sequential'" then="checked" else="" }% />
If
DIFFRENDERSTYLE
isn't set, no radio buttons will be lit. The user can choose (or not choose). Sequential is still the default even if a choice isn't made.
But if
DIFFRENDERSTYLE
is set, the correct radio button would be lit as opposed to a hard-coded choice.
--
VickiBrown - 08 Apr 2010
thanks vicki. if you attach a complete patch file, i will review it and check it in.
--
WillNorris - 12 Apr 2010
This was not difficult to fix. I also noticed that the setting has not been documented well - see new task
Item8905.
--
ArthurClemens - 13 Apr 2010
this was fixed in trunk on a different task - this oneis just 1.0.10
--
SvenDowideit - 25 Aug 2010