Item8621: In attachment tables the filetypes not known are shown as else

pencil
Priority: Urgent
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component:
Branches:
Reported By: KennethLavrsen
Waiting For:
Last Change By: CrawfordCurrie
The new ICON feature is broken and attachment tables are broken

If you look at a topic with an attachment of an unknown filetype you see the word "else" instead of the else icon.

Well that is because of a bug in Attach.pm where %ICON{"'.$file.'" alt="else"}% should have been %ICON{"'.$file.'" alt="else"}%

But when I correct it, I get the filename displayed and still no else icon. So ICON is also broken.

Unit tests already failed but for a test that has nothing to do with ICON. So the ICON unit tests are not showing the bug either.

You have to try features in the browser. The strange thing is that in a topic ICON works. It does not work in an Attachment table context.

-- KennethLavrsen - 26 Feb 2010

Well, of course I try features in the browser. And what you describe above seems to work fine; see http://trunk.foswiki.org/Sandbox/IconTest (.save is not a known filetype)

I don't understand your remark about a bug in Attach.pm. The "before" and "after" strings appear identical to me.

-- CrawfordCurrie - 26 Feb 2010

I checked in a fix for what I suspect was the error you spotted in Attach.pm. The testcase was just plain wrong.

-- CrawfordCurrie - 26 Feb 2010

Feedback on IRC. OK, worked it out, thanks.

-- CrawfordCurrie - 26 Feb 2010

 

ItemTemplate edit

Summary In attachment tables the filetypes not known are shown as else
ReportedBy KennethLavrsen
Codebase trunk
SVN Range
AppliesTo Engine
Component
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:bc18a16025ba distro:87b9ab8c4dec
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r4 - 26 Feb 2010, CrawfordCurrie
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy