Item8477: Strikeone should warn users if they have have js turned off
Priority: Urgent
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component:
Branches:
I installed noscript on my netbook, and suddenly, I was losing every edit I made on foswiki.org and trunk.foswiki.org
- edit topic (you get raw edit)
- hit save
- see 'Warning! Confirmation required' dialog
- hit 'OK', as it says '# Press OK to confirm that this change was intentional.'
- goes to view topic and no save has occurred.
I'm not thrilled that our protection breaks legitimate usage with js off
but a
much bigger issue is that there is nothing telling the innocent user that they are about to lose their work, or why.
--
SvenDowideit - 07 Feb 2010
This is a very real issue, but I'm somewhat at a loss to know what to do about it. Suggestions are welcome, code even more welcome.
--
CrawfordCurrie - 11 Mar 2010
Since strikeone may not be enabled .
Best would be to disable edit when JS is not enabled AND strikeone is enabled. This means telling the JS if strikeone is enabled. I am no JS expert but I assume it is possible but a bit messy.
I personally consider this less urgent. I think very few users run with JS off these days because nothing on the internet works without anymore.
--
KennethLavrsen - 11 Mar 2010
How does the server know JS is disabled? How does it know it has been disabled by the user, rather than it's been disabled because someone is trying a cross-posting hack?
There is no automatic, safe solution to this without fatally weakening the protection that strikeone offers. The only option is to add a message to the confirmation dialog that says something like:
"If JS is off, then go back in the browser and turn it on before trying to save again" if strikeone is enabled.
After some experimentation, I can make the message rewrite using onload JS. Not sure how reliable it will be, but worth a try.
--
CrawfordCurrie - 24 Mar 2010