Item8426: 'Use of uninitialized value' message in kinoupdate

From Support.Question332.

Proposed fix by BenBomgardner:

Line 228: lib/Foswiki/Contrib/KinoSearchContrib/Index.pm

next if ( ( !defined($topicName) ) || ( $skipTopics{"$web.$topicName"} ) || ( $skipTopics{$topicName} ) );

-- AndrewJones - 26 Jan 2010

what about $changes? i went with this:

-        next if ( (!$changes) || ( $skipTopics{"$web.$topicName"} ) || ( $skipTopics{$topicName} ) );
+        next if ( ( !defined $topicName ) || (!$changes) || ( $skipTopics{"$web.$topicName"} ) || ( $skipTopics{$topicName} ) );

-- WillNorris - 26 Feb 2010

please change the following or we are getting an error Global symbol "$changes" requires explicit package name at /var/www/foswiki/lib/Foswiki/Contrib/KinoSearchContrib/Index.pm line 228.

--- lib/Foswiki/Contrib/KinoSearchContrib/Index.pm.bak 2010-03-12 00:54:05.000000000 +0100
+++ lib/Foswiki/Contrib/KinoSearchContrib/Index.pm     2010-04-13 19:54:38.839943713 +0200
@@ -225,7 +225,7 @@
         my ( $topicName, $userName, $changeTime, $revision ) =
           split( /\t/, $change );

-        next if ( ( !defined $topicName ) || (!$changes) || ( $skipTopics{"$web.$topicName"} ) || ( $skipTopics{$topicName} ) );
+        next if ( ( !defined $topicName ) || (!$change) || ( $skipTopics{"$web.$topicName"} ) || ( $skipTopics{$topicName} ) );

         if ( ( %exclude ) || ( !$exclude{$topicName} ) ) {

-- StefanStidl - 13 Apr 2010

Thanks Stefan. I have uploaded a new version with the fix.

-- AndrewJones - 14 Apr 2010

Commenting is disabled while not logged in