Item8037: fails to check txt files on an andrew file system

pencil
Priority: Enhancement
Current State: Closed
Released In:
Target Release:
Applies To: Extension
Component: DBCacheContrib
Branches:
Reported By: Foswiki:Main.MichaelDaum
Waiting For:
Last Change By: MichaelDaum
Before getting filetime, it unnecessarily tests files for readability. A file-exists is enuf and does not interfer badly with ACLs on an Andrew File System.

--- lib/TWiki/Contrib/DBCacheContrib/FileTime.pm        (revision 1787)
+++ lib/TWiki/Contrib/DBCacheContrib/FileTime.pm        (working copy)
@@ -43,7 +43,7 @@
 sub uptodate {
     my $this = shift;
     my $file = $this->{file};
-    if ( -r $file && defined( $this->{time} )) {
+    if ( -f $file && defined( $this->{time} )) {
         my @sinfo = stat( $file );
         my $fileTime = $sinfo[9];
         if ( defined( $fileTime) && $fileTime == $this->{time} ) {
@@ -94,4 +94,18 @@
     $this->{time} = $archive->readInt();
 }

-- MichaelDaum - 07 Jan 2009

ItemTemplate edit

Summary fails to check txt files on an andrew file system
ReportedBy Foswiki:Main.MichaelDaum
Codebase
SVN Range Foswiki-1.0.0-beta3, Fri, 02 Jan 2009, build 1697
AppliesTo Extension
Component DBCacheContrib
Priority Enhancement
CurrentState Closed
WaitingFor
Checkins DBCacheContrib:281228a05b12
ReleasedIn
Topic revision: r2 - 08 Jan 2009, MichaelDaum
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy