Item8037: fails to check txt files on an andrew file system
Priority: Enhancement
Current State: Closed
Released In:
Target Release:
Before getting filetime, it unnecessarily tests files for readability. A file-exists is enuf and does not interfer badly with
ACLs on an Andrew File System.
--- lib/TWiki/Contrib/DBCacheContrib/FileTime.pm (revision 1787)
+++ lib/TWiki/Contrib/DBCacheContrib/FileTime.pm (working copy)
@@ -43,7 +43,7 @@
sub uptodate {
my $this = shift;
my $file = $this->{file};
- if ( -r $file && defined( $this->{time} )) {
+ if ( -f $file && defined( $this->{time} )) {
my @sinfo = stat( $file );
my $fileTime = $sinfo[9];
if ( defined( $fileTime) && $fileTime == $this->{time} ) {
@@ -94,4 +94,18 @@
$this->{time} = $archive->readInt();
}
--
MichaelDaum - 07 Jan 2009