Item6086: TSA DENYTOPICVIEW causes crash

pencil
Priority: Urgent
Current State: Closed
Released In: 1.0.0
Target Release: patch
Applies To: Engine
Component:
Branches:
Reported By: TWiki:Main.SvenDowideit
Waiting For:
Last Change By: KennethLavrsen
 
Can't locate object method "request_uri" via package "TWiki::Request" at /home/wikiring/home.org.au/core/lib/TWiki/LoginManager/ApacheLogin.pm line 91.
    TWiki::LoginManager::ApacheLogin::forceAuthentication('TWiki::LoginManager::ApacheLogin=HASH(0x8758940)') called at /home/wikiring/home.org.au/core/lib/TWiki/UI.pm line 182
    TWiki::UI::__ANON__('TWiki::AccessControlException=HASH(0x8b0dfd0)', 'SCALAR(0x8268b20)') called at /usr/share/perl5/Error.pm line 339
    eval {...} called at /usr/share/perl5/Error.pm line 329
    Error::subs::run_clauses('HASH(0x8a8e74c)', 'TWiki::AccessControlException=HASH(0x8b0dfd0)', 'undef', 'ARRAY(0x826c40c)') called at /usr/share/perl5/Error.pm line 426
    Error::subs::try('CODE(0x8185e0c)', 'HASH(0x8a8e74c)') called at /home/wikiring/home.org.au/core/lib/TWiki/UI.pm line 246
    TWiki::UI::execute('TWiki::Request=HASH(0x81ea990)', 'CODE(0x8507a80)', 'view', 1) called at /home/wikiring/home.org.au/core/lib/TWiki/UI.pm line 125
    TWiki::UI::handleRequest('TWiki::Request=HASH(0x81ea990)') called at /home/wikiring/home.org.au/core/lib/TWiki/Engine/CGI.pm line 49
    TWiki::Engine::CGI::run('TWiki::Engine::CGI=HASH(0x83def94)') called at view line 42.

 
when I added DENYTOPICVIEW=TWikiGuest
its supposed to give an oops screen saying no permission to view... 

-- TWiki:Main/SvenDowideit - 21 Oct 2008

This is a CGI compatibility issue in TWiki::Request. There is no request_uri method and REQUEST_URI is not CGI-Standard. I'll solve this by adding this method and make it verify if the environment variable exist. If yes, return its value and if not construct what Apache would put on it.

I'll commit as soon as I get the time to code and test this wink

-- TWiki:Main.GilmarSantosJr - 21 Oct 2008

i eliminated the call to request_uri; much more efficient.

-- CrawfordCurrie - 19 Nov 2008 - 18:00

ItemTemplate edit

Summary TSA DENYTOPICVIEW causes crash
ReportedBy TWiki:Main.SvenDowideit
Codebase
SVN Range TWiki-5.0.0, Sun, 05 Oct 2008, build 17588
AppliesTo Engine
Component
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:09a103da3b7b
TargetRelease patch
ReleasedIn 1.0.0
Topic revision: r5 - 26 Dec 2008, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy