You are here: Foswiki>Tasks Web>Item358 (27 Feb 2009, KennethLavrsen)Edit Attach

Item358: WysiwygPlugin/TranslatorTests.pm uses HTML::Diff for nothing

pencil
Priority: Normal
Current State: Closed
Released In:
Target Release: n/a
Applies To: Engine
Component: WysiwygPlugin
Branches:
Reported By: OlivierRaginel
Waiting For: Main.OlivierRaginel
Last Change By: KennethLavrsen
* Failed to use TranslatorTests: Can't locate HTML/Diff.pm in @INC (@INC contains: ../../bin...) at core/test/unit/WysiwygPlugin/TranslatorTests.pm line 1729.

HTML::Diff is not used in this test, thus removing it doesn't hurt.

According to the code, HTML::Diff seems to be used by the tests, but I just couldn't find any which needed it, and only TranslatorTests from Wysiwyg uses it.

The documentation seems to assume TestFixturePlugin needs it, but after checking the code, TestFixturePlugin uses Algorithm::Diff, not HTML::Diff.

I'll remove it if no-one objects. And I'll fix the documentation, etc..., of course!

-- OlivierRaginel - 30 Nov 2008

I used it for a while back when I first started writing tests that compare HTML, but abandoned it due to the number of bugs. As long as nothing breaks you can remove it.

-- CrawfordCurrie - 01 Dec 2008

ItemTemplate edit

Summary WysiwygPlugin/TranslatorTests.pm uses HTML::Diff for nothing
ReportedBy OlivierRaginel
Codebase
SVN Range TWiki-4.2.3, Wed, 06 Aug 2008, build 17396
AppliesTo Engine
Component WysiwygPlugin
Priority Normal
CurrentState Closed
WaitingFor OlivierRaginel
Checkins distro:f97c98f48b68
TargetRelease n/a
ReleasedIn
Topic revision: r5 - 27 Feb 2009, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy