Every run of a
view
script calls
TWiki::Access::checkAccessPermission
(at least) twice, with nothing much happening in between:
-
TWiki::Store::readTopicRaw
directly calls checkAccessPermission
- after return from the Store,
TWiki::UI::View::view
calls TWiki::UI::checkAccess
, passing the topic text. This routine, however, ignores the topic text and calls checkAccessPermission
again.
This has to be investigated further. But since
checkAccessPermission
needs preferences from both the topic in question and the WebPreferences, double work should be avoided even if it is cached.
-- HJ
it appears this is no longer the case in foswiki trunk
[Fri May 01 16:19:24 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to System.InterWikis
[Fri May 01 16:19:24 2009] [error] [client 127.0.1.1] OK, permitted
[Fri May 01 16:19:24 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to System.SmiliesPlugin
[Fri May 01 16:19:24 2009] [error] [client 127.0.1.1] OK, permitted
[Fri May 01 16:19:24 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to Main.WebHome
[Fri May 01 16:19:24 2009] [error] [client 127.0.1.1] OK, permitted
[Fri May 01 16:19:24 2009] [error] [client 127.0.1.1] ALLOW:
[Fri May 01 16:19:24 2009] [error] [client 127.0.1.1] DENY:
[Fri May 01 16:19:25 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to Main.WebLeftBarExample
[Fri May 01 16:19:25 2009] [error] [client 127.0.1.1] OK, permitted
[Fri May 01 16:19:25 2009] [error] [client 127.0.1.1] ALLOW:
[Fri May 01 16:19:25 2009] [error] [client 127.0.1.1] DENY:
[Fri May 01 16:19:25 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to System.WebLeftBarLogin
[Fri May 01 16:19:25 2009] [error] [client 127.0.1.1] OK, permitted
[Fri May 01 16:19:25 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to System.WebLeftBarWebsList
[Fri May 01 16:19:25 2009] [error] [client 127.0.1.1] OK, permitted
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to DimensionData
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] access not allowed on web
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to FoswikiApplicationData
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] OK, permitted
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] ALLOW:
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] DENY:
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to OSDC
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] OK, permitted
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] ALLOW:
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] DENY:
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to Presentations
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] OK, permitted
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] ALLOW:
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] DENY:
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to Sandbox
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] OK, permitted
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] ALLOW:
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] DENY:
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to System
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] OK, permitted
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to SystemAdmin
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] OK, permitted
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to TestCases
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] OK, permitted
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to System.WebTopBar
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] OK, permitted
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to System.WebTopBarExample
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] OK, permitted
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to System.LanguageSelector
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] OK, permitted
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] Check VIEW access BaseUserMapping_666 to System.WebBottomBarExample
[Fri May 01 16:19:26 2009] [error] [client 127.0.1.1] OK, permitted
--
SvenDowideit - 01 May 2009