Item2607: build.pl cannot release 4 of the core extensions on trunk

While setting up a deb autobuilder for individual extensions, I found that 4 of the plugins/contribs in the core MANIFEST on trunk cannot be released (built into .tgz files) by build.pl. The autobuilder requires that every file in the plugin MANIFEST be present in the release tarball. Deleting these 4 from core/lib/MANIFEST allows the autobuild to succeed (it fails if anything in the MANIFEST is missing from the release tarball).

• EditTablePlugin - nothing obviously wrong, and lots of time spent looking so far
• TinyMCEPlugin - dupes, comments, and editor cruft found in MANIFEST
• BehaviourContrib - missing newline at end
• JSCalendarContrib - comment and extraneous newline

These fixes have not been enough locally to fix the build.pl failures with these contribs though. All remaining entries were verified to be present in the repository.

To get trunk as a whole back into buildable shape, should these 4 be dropped from core/lib/MANIFEST until they are ready to return?

For comparison, a contrib that fails vs a contrib that succeeds:

cd core/tools
./build.pl release -auto
 ...
Building release 03 Aug 2008 of JSCalendarContrib, from version 4533 (2009-07-22)
Installing ../PatternSkin/lib/Foswiki/Contrib/PatternSkin in /tmp/MDvP4LfZUz/Foswiki-1.1.0-dev-auto

Building release 18 Dec 2009 of MailerContrib, from version 5821 (2009-12-18)
MD5 checksums in /home/dld/git/foswiki/MailerContrib/MailerContrib.md5
SHA1 checksums in /home/dld/git/foswiki/MailerContrib/MailerContrib.sha1
.tgz in /home/dld/git/foswiki/MailerContrib/MailerContrib.tgz
.zip in /home/dld/git/foswiki/MailerContrib/MailerContrib.zip
.txt in /home/dld/git/foswiki/MailerContrib/MailerContrib.txt
_installer in /home/dld/git/foswiki/MailerContrib/MailerContrib_installer
...

---

I'll fix TinyMCEPlugin.

Later: The MANIFEST for TinyMCEPlugin is exactly the same for Release01x00 vs trunk. It also builds fine from both places?

-- PaulHarvey - 08 Jan 2010

It's probably minifier. The behavior of the Debian/sid minifier from libjavascript-minifier-xs-perl is different. All four of these extensions of .js files.

-- DrakeDiedrich - 08 Jan 2010

Release branch is also affected, but only for Javascript::Minifier::XS platforms. This means the 4 extensions aren't in the autobuilt .debs, but are in the RC1 and presumably would be in the official release. http://debmarshal.debian.net/foswiki/pool/main/f/foswiki/foswiki_1.0.9-auto5972.orig.tar.gz is only 2.5M, while http://sourceforge.net/projects/foswiki/files/foswiki/Foswiki-1.0.9-rc1.tgz is 4.1M. Since it won't actually end up with missing extensions in the release branch it isn't critical, but it would be nice to be able to test the extensions in the .debs. The patch only affects release and .deb building, it shouldn't affect the runtime (assuming release works at all). Lavr, what do you think, should it go into the release branch, or wait for the next dev cycle?

JSCalendar was also missing a Config.spec file - added the documented entries. I don't know if they're correct, but it makes MANIFEST match the tarball.

-- DrakeDiedrich - 08 Jan 2010

If the change only affects build then we have two options.

Fix and do a lot of testing of two build to make sure they are identical before and after.

Or wait till a few minutes after I have built the 1.0.9. This way the debs can be built right after.

I am still not sure if I release this weekend. Depends on feedback.

I am setting back to New. If there is an open issue the bug should not be in waiting for release. In 5 days we have all forgotten about it. We cannot remember all these actions and bugs so never close until you are Done and Done.

Or raise a new bug item for the missing part. We do that when we want partial work in release notes and defer something else till later release.

-- KennethLavrsen - 09 Jan 2010

This is a BuildContrib bug that affects installations which have the ::XS minifier installed.

BTW. ::XS minifier produces larger output than JavaScript::Minifier.

Setting the bug to BuildContrib, which tries to call Minifier::XS the same way it would ::Minifier, which is wrong.

-- PaulHarvey - 21 Feb 2010

Closing. BuildContrib is not part of distribution so no need for note in release note

-- KennethLavrsen - 22 Feb 2010