You are here: Foswiki>Tasks Web>Item2338 (11 Nov 2009, SvenDowideit)Edit Attach

Item2338: generalise and extract the callback code in SEARCH

pencil
Priority: Enhancement
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component:
Branches:
Reported By: SvenDowideit
Waiting For: Main.SvenDowideit
Last Change By: SvenDowideit
there's a bunch of maddening

if (defined $callback) {
}else{
}

code, which is pretty redundant, and decreases readibility..

I'm going to assume that the progressive outputing of results is still used.. but who knows..

sadly, intentionally breaking the code shows that there are zero unit tests for that codepath. so it'll be another winding road of discovery.

-- SvenDowideit - 08 Nov 2009

done, just a little simpler smile

-- SvenDowideit - 11 Nov 2009

ItemTemplate edit

Summary generalise and extract the callback code in SEARCH
ReportedBy SvenDowideit
Codebase
SVN Range Foswiki-1.0.7, Sun, 20 Sep 2009, build 5061
AppliesTo Engine
Component
Priority Enhancement
CurrentState Closed
WaitingFor SvenDowideit
Checkins distro:e349d5d06dfa distro:49f0351c6b3d distro:ce99047048ae
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r5 - 11 Nov 2009, SvenDowideit
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy