Item2169: Pattern skin style.css missing #patternPage

In PatternSkin, style.css, The following section:

#patternPage {
   font-family:arial, verdana, sans-serif;
   line-height:1.5em; /*S1*/
   /* change font size here */
   font-size:105%;
}

was completely replaced by

.foswikiPage {
   font-family:arial, verdana, sans-serif;
   line-height:1.5em; /*S1*/
   /* change font size here */
   font-size:105%;
}

This lost the font for the overall page layout.

I believe that both should remain. One is selected by id= and the other by class name. By deleting the #patternPage block, any selection by id is lost.

---

I can see that for compatibility #patternPage should still exist for a while, but I would like to deprecate the use because the styles overlap. foswikiPage is now part of the CSS interface. And the class definition is more flexible than the id.

-- ArthurClemens - 28 Sep 2009

At this point I'm not quite sure why my site lost the formatting. I ran the update using the 22 September version of the script in HowDoIUpgradeSafelyACustomizedFoswikiInstallation I'm guessing then that some other file has not been correctly updated.

Searching the file system for #patternPage had a large number of "hits", so I'm not sure what might have been missed either by my update, or in the CSS. I ran the script on a test site first, and did not encounter the same problem.

Reduced urgency to Normal. If we don't keep the #patternPage entry, then some documentation on what to look for to resolve issues, and/or some instructions on how to restore it if needed would probably be fine.

I'll try to figure out what happened and will add a note to the HowDoI... page

---

Ignore the following - had a local site configuration issue: Somewhat related, the PatternSkinCustomization documentation on Foswiki.org is very much out of sync with the docs shipped with 1.0.7, and SVN, trunk and release branch. The shipped documentation still contains obsolete instructions that no longer work on 1.0.7. The documentation on F.O appears to be correct, but is not checked into SVN, so shipped docs are wrong.

For example, shipped instructions on how to change Top Bar Dimensions reference creating a template named topbardimensions but this is no longer expanded by Foswiki. Revised instructions use a stylesheet.

---

Changed to "No Action Required". Once local configuration issues were resolved, the site renders correctly without the #patternPage definition. And addition of the definition causes other issues.