Item1950: AddToHeadTests.pl broken in trunk 4700

Unit test broken: AddToHeadTests.pl.

I have been trying to debug an infuriating AddToHead() problem where the head fragment to be "added" only gets partially expanded (the html <!--... comment section) where it's supposed to, and then fully expanded somewhere else down past where it was needed (resulting in various JS libs failing).

So I tried to write a unit test for this, but it seems the unit tests are broken.

Using a fully working svn based install (revision 4700), I ran the following:

sudo -u www-data bash -c "export FOSWIKI_HOME=$FOSWIKI_HOME && ../bin/TestRunner.pl FoswikiSuite.pm"

And the result is: 1848 of 1854 test cases passed

As for the 6 failed test cases? All AddToHeadTest.pl (running just the AddToHeadTest.pl gives 0 of 6 test cases passed):

Running AddToHeadTests
   AddToHeadTests::testFuncSimple
*** 
Expected:'<!-- first --> QQQ'
 But got:'%RENDERHEAD%'
 at /usr/local/src/foswiki/foswiki/lib/Unit/TestCase.pm line 135
   Unit::TestCase::assert_equals('AddToHeadTests=HASH(0x2efd970)', '<!-- first --> QQQ', '%RENDERHEAD%') called at AddToHeadTests.pm line 84
   AddToHeadTests::testFuncSimple('AddToHeadTests=HASH(0x2efd970)') called at /usr/local/src/foswiki/foswiki/lib/Unit/TestRunner.pm line 107
   Unit::TestRunner::__ANON__() called at /usr/local/src/foswiki/core/lib/CPAN/lib/Error.pm line 379
   eval {...} called at /usr/local/src/foswiki/core/lib/CPAN/lib/Error.pm line 371
   Error::subs::try('CODE(0x2efda30)', 'HASH(0x34afc40)') called at /usr/local/src/foswiki/foswiki/lib/Unit/TestRunner.pm line 128
   Unit::TestRunner::start('Unit::TestRunner=HASH(0x2bbbe90)', 'AddToHeadTests.pm') called at ../bin/TestRunner.pl line 99
 at /usr/local/src/foswiki/core/test/unit/FoswikiTestCase.pm line 25
   FoswikiTestCase::__ANON__('\x{a}Expected:\'<!-- first --> QQQ\'\x{a} But got:\'%RENDERHEAD%\'\x{a} a...') called at /usr/local/src/foswiki/foswiki/lib/Unit/TestCase.pm line 130
   Unit::TestCase::assert('AddToHeadTests=HASH(0x2efd970)', '', 'Expected:\'<!-- first --> QQQ\'\x{a} But got:\'%RENDERHEAD%\'\x{a}') called at /usr/local/src/foswiki/foswiki/lib/Unit/TestCase.pm line 135
   Unit::TestCase::assert_equals('AddToHeadTests=HASH(0x2efd970)', '<!-- first --> QQQ', '%RENDERHEAD%') called at AddToHeadTests.pm line 84
   AddToHeadTests::testFuncSimple('AddToHeadTests=HASH(0x2efd970)') called at /usr/local/src/foswiki/foswiki/lib/Unit/TestRunner.pm line 107
   Unit::TestRunner::__ANON__() called at /usr/local/src/foswiki/core/lib/CPAN/lib/Error.pm line 379
   eval {...} called at /usr/local/src/foswiki/core/lib/CPAN/lib/Error.pm line 371
   Error::subs::try('CODE(0x2efda30)', 'HASH(0x34afc40)') called at /usr/local/src/foswiki/foswiki/lib/Unit/TestRunner.pm line 128
   Unit::TestRunner::start('Unit::TestRunner=HASH(0x2bbbe90)', 'AddToHeadTests.pm') called

   AddToHeadTests::testFuncStyle
*** 
Expected:'<!-- PATTERN_STYLE --> <link id="twikiLayoutCss" rel="stylesheet" type="text/css" href="PatternSkin/layout.css" media="all" />'
 But got:'%RENDERHEAD%'
 at /usr/local/src/foswiki/foswiki/lib/Unit/TestCase.pm line 135
   Unit::TestCase::assert_equals('AddToHeadTests=HASH(0x2efd970)', '<!-- PATTERN_STYLE --> <link id="twikiLayoutCss" rel="stylesh...', '%RENDERHEAD%') called at AddToHeadTests.pm line 124
   AddToHeadTests::testFuncStyle('AddToHeadTests=HASH(0x2efd970)') called at /usr/local/src/foswiki/foswiki/lib/Unit/TestRunner.pm line 107
   Unit::TestRunner::__ANON__() called at /usr/local/src/foswiki/core/lib/CPAN/lib/Error.pm line 379
   eval {...} called at /usr/local/src/foswiki/core/lib/CPAN/lib/Error.pm line 371
   Error::subs::try('CODE(0x3627410)', 'HASH(0x29e7d10)') called at /usr/local/src/foswiki/foswiki/lib/Unit/TestRunner.pm line 128
   Unit::TestRunner::start('Unit::TestRunner=HASH(0x2bbbe90)', 'AddToHeadTests.pm') called at ../bin/TestRunner.pl line 99
 at /usr/local/src/foswiki/core/test/unit/FoswikiTestCase.pm line 25
   FoswikiTestCase::__ANON__('\x{a}Expected:\'<!-- PATTERN_STYLE --> <link id="twikiLayoutCss" ...') called at /usr/local/src/foswiki/foswiki/lib/Unit/TestCase.pm line 130
   Unit::TestCase::assert('AddToHeadTests=HASH(0x2efd970)', '', 'Expected:\'<!-- PATTERN_STYLE --> <link id="twikiLayoutCss" r...') called at /usr/local/src/foswiki/foswiki/lib/Unit/TestCase.pm line 135
   Unit::TestCase::assert_equals('AddToHeadTests=HASH(0x2efd970)', '<!-- PATTERN_STYLE --> <link id="twikiLayoutCss" rel="stylesh...', '%RENDERHEAD%') called at AddToHeadTests.pm line 124
   AddToHeadTests::testFuncStyle('AddToHeadTests=HASH(0x2efd970)') called at /usr/local/src/foswiki/foswiki/lib/Unit/TestRunner.pm line 107
   Unit::TestRunner::__ANON__() called at /usr/local/src/foswiki/core/lib/CPAN/lib/Error.pm line 379
   eval {...} called at /usr/local/src/foswiki/core/lib/CPAN/lib/Error.pm line 371
   Error::subs::try('CODE(0x3627410)', 'HASH(0x29e7d10)') called at /usr/local/src/foswiki/foswiki/lib/Unit/TestRunner.pm line 128
   Unit::TestRunner::start('Unit::TestRunner=HASH(0x2bbbe90)', 'AddToHeadTests.pm') called

   AddToHeadTests::testSimple
*** 
Expected:'<!--  --> QQQ'
 But got:'%RENDERHEAD%'
 at /usr/local/src/foswiki/foswiki/lib/Unit/TestCase.pm line 135

... and so on.

I hope it's okay to mark this as urgent; my judgment was that it's worth being a release blocker.

-- PaulHarvey - 21 Aug 2009

I realise now this is almost certainly related to Item1697. Closing.

-- PaulHarvey - 21 Aug 2009