Item1911: CompareRevisionsAddOn always markes tables with a change bar and often red/green also

pencil
Priority: Urgent
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Extension
Component: CompareRevisionsAddOn
Branches:
Reported By: KennethLavrsen
Waiting For: Main.KennethLavrsen
Last Change By: KennethLavrsen
It seems that even when you have not touched a table at all, CompareRevisionsAddOn marks the table as changed.

It has not always been like this.

I have the feeling the reason is that the rendering in HTML of table have changed so that they are shown differently in an old revision than in current revision.

I need to analyse this further. It requires digging deeper into this plugin than I have been before. It is rather annoying.

-- KennethLavrsen - 09 Aug 2009

Ah. It is the table ID which is not reset when you read the same topic twice and present it twice.

A table rendered as HTML looks like

<table cellspacing="0" id="table5" cellpadding="0" class="foswikiTable" rules="rows" border="1">

And it is the id where the table number continues counting up.

I need to investigate if this is something I should fix in the core or TablePlugin or it is CRAO that needs to deal with this.

-- KennethLavrsen - 09 Aug 2009

I have a hack that works well.

But maybe a plugin expert can give me a hint how to "reset" another plugin before calling it again.

I need to reset the table counter in TablePlugin.

-- KennethLavrsen - 12 Sep 2009

ItemTemplate edit

Summary CompareRevisionsAddOn always markes tables with a change bar and often red/green also
ReportedBy KennethLavrsen
Codebase
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Extension
Component CompareRevisionsAddOn
Priority Urgent
CurrentState Closed
WaitingFor KennethLavrsen
Checkins distro:d8bcd00472a8
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r5 - 13 Sep 2010, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy