You are here: Foswiki>Tasks Web>Item1624 (20 Apr 2010, LynnwoodBrown)Edit Attach

Item1624: TCAO TopicClassificationAddOn - "Bad Request: GET denied for save"

pencil
Priority: Normal
Current State: Waiting for Release
Released In:
Target Release: n/a
Applies To: Extension
Component: TopicClassificationAddOn
Branches:
Reported By: MilanMasek
Waiting For: Main.LynnwoodBrown
Last Change By: LynnwoodBrown
-- MilanMasek - 15 May 2009

Hi,

When I´m using TopicClassificationAddOn (TCAO) it produce nasty error "Bad Request: GET denied for save". E.g. when you want to install its functionality into another Web using page System/TopicClassificationAddOn. The same when you want to add type or area on pages TopicTypes or SubjectAreas.

My system configuration is:
  • Foswiki: 1.0.5
  • OS: CentOS Linux 5.2
  • Perl: 5.8.8
  • Apache: 2.2.3

Does anybody know how to solve this? Is it configuration problem or bug in a code?

If you need more information, please let me know.

Thanks to all

Milan

I've run into a similar problem with TCAO. However, I upgraded from Foswiki-1.0.4 by simply copying the Foswiki-upgrade-1.0.5 package on top of the existing 1.0.4 version. I'm able to create and save topics, but cannot create new TopicTypes or SubjectTypes. I'm assuming this is because Foswiki-1.0.5 contains Item1458: Don't allow saving data when HTTP method is GET. One of the scripts within TCAO, or one of the scripts it depends on, must still be using HTTP method GET when trying to save data?

System:
  • Foswiki: 1.0.5
  • OS: Ubuntu 9.0.4
  • Perl 5.10.0
  • Apache: 2.2.11

-- RichardDeVriese - 28 May 2009

My apologies to folks for not picking up on your distress calls earlier! The fix is very easy:
  • Edit RenderInstallTopicClassification in the TCAO web.
  • Find the html form tag that says:
<form name="installTCAO" action="" >
and add a "post" attribute as so:
<form name="installTCAO" action="" method="post" >
.
  • Save the topic and you're good to go.

This glitch was due to the code changes necessitated by Support.SecurityAlert-CVE-2009-1434. There was no vulnerability related to TCAO but the default "get" method is no longer allowed for topic saves.

-- LynnwoodBrown - 05 Jun 2009

i applied the patch and re-released the plugin.

-- WillNorris - 06 Feb 2010

Typo in the update Will.. http://trac.foswiki.org/changeset/6229

<form name="installTCAO" action="%SCRIPTURL{save}%/" action="post" >

should read:

<form name="installTCAO" action="%SCRIPTURL{save}%/" method="post" >

Should I fix this?

-- PadraigLennon - 27 Feb 2010

thanks, fixed, and uploaded again.

-- WillNorris - 27 Feb 2010

This feature is broken as far as I can see.. The topic TCAO.WebHome topic states:

You will be sent immediately to the TopicClassification topic in the choosen web and presented further instructions for setting up TCAO within the web.

The save is to the target web is broken. The topic Main.!TopicClassification is saved each time. The form (which is included from the topic TCAO.!RenderInstallTopicClassification) uses javascript to build the name of the topic name.

The following change fixes the issue:

<option value="$name">$name</option>

-- PadraigLennon - 27 Feb 2010

I just checked in the little fix PadraigLennon kindly pointed out.

-- LynnwoodBrown - 04 Mar 2010
Topic revision: r18 - 20 Apr 2010, LynnwoodBrown
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy