Item1583: In links, class names foswikiCurrentWebHomeLink and foswikiCurrentTopicLink are concatenated
Priority: Normal
Current State: No Action Required
Released In:
Target Release: n/a
Applies To: Engine
Component: Rendering
Branches:
in sub _renderExistingWikiWord in lib/Foswiki/Render.pm,
The code:
$currentWebHome = 'foswikiCurrentWebHomeLink '
...
$currentTopic = 'foswikiCurrentTopicLink'
...
my $cssClassName = "$currentTopic$currentWebHome";
make links to the current topic if we are the home tomic have the bogus CSS class
foswikiCurrentTopicLinkfoswikiCurrentWebHomeLink
instead of the proper separated 2 classes
foswikiCurrentTopicLink foswikiCurrentWebHomeLink
This bug seems to have been present since Foswiki 1.0, but was not in TWiki, where the same code was:
$currentWebHome = 'twikiCurrentWebHomeLink '
...
$currentTopic = 'twikiCurrentTopicLink '
...
push( @attrs, class => $currentTopic.$currentWebHome.'twikiLink', href => $href );
I will thus remove a space from $currentWebHome and add one to $currentTopic in some days if nobody objects (and if my tests are sucecssful)
The code has changed since this report was filed; it's now done much more sensibly.
No action required.
--
CrawfordCurrie - 25 Jun 2010