Item1583: In links, class names foswikiCurrentWebHomeLink and foswikiCurrentTopicLink are concatenated

pencil
Priority: Normal
Current State: No Action Required
Released In:
Target Release: n/a
Applies To: Engine
Component: Rendering
Branches:
Reported By: ColasNahaboo
Waiting For:
Last Change By: CrawfordCurrie
in sub _renderExistingWikiWord in lib/Foswiki/Render.pm,

The code:
    $currentWebHome = 'foswikiCurrentWebHomeLink  '
...
    $currentTopic = 'foswikiCurrentTopicLink'
...
    my $cssClassName = "$currentTopic$currentWebHome";

make links to the current topic if we are the home tomic have the bogus CSS class foswikiCurrentTopicLinkfoswikiCurrentWebHomeLink instead of the proper separated 2 classes foswikiCurrentTopicLink foswikiCurrentWebHomeLink

This bug seems to have been present since Foswiki 1.0, but was not in TWiki, where the same code was:

    $currentWebHome = 'twikiCurrentWebHomeLink '
...
    $currentTopic = 'twikiCurrentTopicLink '
...
    push( @attrs, class => $currentTopic.$currentWebHome.'twikiLink', href => $href );

I will thus remove a space from $currentWebHome and add one to $currentTopic in some days if nobody objects (and if my tests are sucecssful)
The code has changed since this report was filed; it's now done much more sensibly.

No action required.

-- CrawfordCurrie - 25 Jun 2010

ItemTemplate edit

Summary In links, class names foswikiCurrentWebHomeLink and foswikiCurrentTopicLink are concatenated
ReportedBy ColasNahaboo
Codebase 1.0.5, 1.0.5 beta1, 1.0.4, 1.0.3, 1.0.2, 1.0.1, 1.0.0, trunk
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Engine
Component Rendering
Priority Normal
CurrentState No Action Required
WaitingFor
Checkins
TargetRelease n/a
ReleasedIn
I Attachment Action Size Date Who Comment
Item1583-v1.patchpatch Item1583-v1.patch manage 689 bytes 07 May 2009 - 15:55 ColasNahaboo apply by patch -p0 <
Topic revision: r2 - 25 Jun 2010, CrawfordCurrie
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy