You are here: Foswiki>Tasks Web>Item1530 (26 Apr 2009, KennethLavrsen)Edit Attach

Item1530: rdiff swaps new and old in trunk

Priority: Normal
Current State: Closed
Released In: 1.1.0
Target Release: minor

Applies To: Engine
Component:
Branches:

Reported By: KennethLavrsen
Waiting For:
Last Change By: KennethLavrsen

With the great code refactor the rdiff logic got reversed so rdiff shows added and removed.

It is easy to understand why it happens.

There is no logic in 1 and 2. And at some point in the code the logic swaps

In UI/Rdiff I have now renamed the variables so we use High and Low for the revision variables.

Additionally I added comments in the other source files so it is documented what 1 and 2 is.

And naturally this also showed clearly where the bug needed to be fixed.

I also noted that the contextLines does not work with RcsLite. It is simply not implemented in the new function. That goes in another bug item. The sequence of old to new is confirmed working also in RcsLite.

-- KennethLavrsen - 26 Apr 2009

ItemTemplate edit

Summary	rdiff swaps new and old in trunk
ReportedBy	KennethLavrsen
Codebase	trunk
SVN Range	Foswiki-1.1.0-dev, Sat, 25 Apr 2009, build 3703
AppliesTo	Engine
Component
Priority	Normal
CurrentState	Closed
WaitingFor
Checkins	distro:81a9e6b7a7bd
TargetRelease	minor
ReleasedIn	1.1.0