You are here: Foswiki>Tasks Web>Item13928 (31 Jan 2018, GeorgeClark)Edit Attach

Item13928: Mistypes to be fixed in the core.

pencil
Priority: Normal
Current State: Closed
Released In: 2.1.3
Target Release: patch
Applies To: Engine
Component:
Branches: master Release02x00 Item13897 Item14033 Release02x01 Item14380 Item14537
Reported By: VadimBelman
Waiting For:
Last Change By: GeorgeClark
 
File
Line
Status
What is wrong
What is expected
1
UnitTestContrib/test/unit/ExtensionInstallerTests.pm
1911
fixed
$this->{_rootdir}
$this->{rootdir}
2
lib/Foswiki/Meta.pm
2612
fixed
$this->{topic}
$this->{_topic}
3
lib/Foswiki/Meta.pm
443 (method load())
fixed
$this used in ASSERT before actually assigned from $proto.
Switch lines – put $this=$proto; before the ASSERT statement.
4
UnitTestContrib/lib/Unit/Request.pm
23
fixed
Duplicated and nested 'foreach $k' has no sense.
Remove one level for loop.
5
test/unit/InitFormTests.pm
836
fixed
$this->{test_user_login}test_user_login is defined in FoswikiFnTestCase only but this test suite is inheriting from FoswikiTestCase.
Replace $this->{test_user_login} with either undef or some meaningful value.
6
lib/Foswiki/Configure/Checkers/Email/SSLCrlFile.pm
75
fixed
Foswiki::Configure::Load::expand
Foswiki::Configure::Load::expanded – just guessing.
7
lib/Foswiki/Configure/Reporter.pm
191 (method hint())
unfixed
$this->{$hint}
$this->{hints}->{$hint}

-- VadimBelman - 19 Jan 2016

#2-6 are fixed only on master.

-- GeorgeClark - 28 Apr 2016

I think it's time to close the task as if there is any more mistypes I would hardly bind them to the original code.

-- VadimBelman - 05 Aug 2016

These are all fixed now on Release02x01 and master. Marking waiting for release.

-- GeorgeClark - 06 Aug 2016
 
Topic revision: r18 - 31 Jan 2018, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy