Item13737: lots of messages in error log when not running VirtualHostingContrib

2015/09/21 09:47:18 [error] 19137#19137: *2436 FastCGI sent in stderr: "DIE Can't locate Foswiki/Contrib/VirtualHostingContrib/VirtualHost.pm in @INC (...)

Below patch basically reverts what has been added by Modell-Aachen as this code constantly fills up the error.logs ... which it shouldn't:

diff --git a/lib/Filesys/Virtual/Foswiki.pm b/lib/Filesys/Virtual/Foswiki.pm
index 679e092..18c2ff0 100644
--- a/lib/Filesys/Virtual/Foswiki.pm
+++ b/lib/Filesys/Virtual/Foswiki.pm
@@ -208,33 +208,6 @@ sub _initSession {
         $this->{session}->{request}->pathInfo( $newPathInfo );
     }
 
-    # meyer@modell-aachen.de
-    # Add support for virtual hosting.
-    # See package VirtualHostingContrib for further details.
-    eval {
-        my $request = $this->{session}->{request};
-        my $host = $request->virtual_host();
-        my $port = $request->virtual_port();
-
-        require Foswiki::Contrib::VirtualHostingContrib::VirtualHost;
-        my $vhost = Foswiki::Contrib::VirtualHostingContrib::VirtualHost->find( $host, $port );
-
-        my $vconfig = $vhost->run( sub {
-            return {
-                PubDir    => $Foswiki::cfg{PubDir},
-                WorkingDir => $Foswiki::cfg{WorkingDir},
-                DataDir           => $Foswiki::cfg{DataDir},
-            };
-                                   } );
-
-        $Foswiki::cfg{PubDir} = $vconfig->{PubDir};
-        $Foswiki::cfg{WorkingDir} = $vconfig->{WorkingDir};
-        $Foswiki::cfg{DataDir} = $vconfig->{DataDir};
-    };
-    if ( $@ ) {
-        # nothing...
-    }
-
     return $this->{session};
 }

Any idea what this piece of code is supposed to fix?

-- MichaelDaum - 21 Sep 2015

Not a clue. Jan?

-- Main.CrawfordCurrie - 29 Sep 2015 - 07:16

No feedback. Going to remove it. Works fine without these lines under VirtualHostingContrib as well as old fassion.

Crawford, any objections creating a new release?

-- MichaelDaum - 08 Mar 2016

No, go for it.

-- Main.CrawfordCurrie - 20 Mar 2016 - 19:11

Commenting is disabled while not logged in