Item13725: SmiliesPlugin can be made a little easier to upgrade with simple css change.
Priority: Low
Current State: Closed
Released In: 2.0.2
Target Release: patch
The new
SmiliesPlugin has en increased number of icons and they look better and are animated.
Cool enhancement
For upgraders that has a Set SMILIESPLUGIN_TOPIC =
MyOwnSmilies they will have copies of all the old 15x15 icons + all their custom icons.
And both the old and the custom icons get scaled up because of the new smiles.css setting
height:1.5em;
This means that an upgrader will either have to put up with blury icons or spend time trying to merge custom icons with the new nicer icons. I am sure he will want to do that eventually but it would be nice not to have this on the long list of upgrade issues.
I tried to remove the the
height:1.5em;
from the smiles.css.
I could not see any visible effects on the new icons. They look just as great.
But on the old icons - the 15x15 are shown at the original size sharp and not blury.
MichaelDaum - you are the CSS expert and also know the effect on your own
NatSkin.
Can the
height:1.5em;
be removed from the smilies.css?
It would be a small thing that makes upgrading just a little bit easier.
--
KennethLavrsen - 17 Sep 2015
Michael, although low priority, this does seem rather innocuous. I'd like to get it into 2.0.2 if it makes sense. Thanks
--
GeorgeClark - 17 Sep 2015
You are right. Go ahead and check in your proposed fix.
--
MichaelDaum - 17 Sep 2015