Item13471: Labels in NatEditPlugin form editor all bold, overrides user preference.

The NatEditPlugin forces field labels in DataForms to be bold by using the TH element to define table headings (see form.natedit.tmpl). This overrides user preferences in the DataForm to have the labels in plain text, bold, italic etc. Foswiki.org running 1.1.9 has many dataforms where readibility is enhanced by utilising different text styles. Propose changing the TH element to TD in form.natedit.tmpl. Downside will be that people using screen readers, search engines, and people utilising CSS will lose benefit of new approach.

-- RiskReward - 23 Jun 2015

Marking this confirmed and bumping it to be a Release Blocker.

Maybe it's just aesthetics, but I find the forms on 1.2 must harder to read, and use. I've noticed the same thing on topics like the ApacheConfigGenerator. The line that renders on 1.2 between form elements just makes things much more readable IMHO. Everything just runs together and bolding everything doesn't really help.

-- GeorgeClark - 23 Jun 2015

Any screenshot welcome. Not sure which table you are refering to, RiskReward. Could you also be a bit more precise which user-provided preferences are overridden using THs in DataForms. Thanks.

Btw using THs in a table are quite commonly used to hold row or column headings. That's what they are for strictly speaking. The rest of it really is only CSS, probably missing styles in PatternSkin.

This is a TH on 1.1.9 as well. Labelling it to PatternSkin.

Here's a patch for NatEditPlugin:

diff --git a/NatEditPlugin/templates/form.natedit.tmpl b/NatEditPlugin/templates/form.natedit.tmpl
index 8c0fe04..c4bb25f 100644
--- a/NatEditPlugin/templates/form.natedit.tmpl
+++ b/NatEditPlugin/templates/form.natedit.tmpl
@@ -19,7 +19,7 @@
 %TAB{"%MAKETEXT{"Form"}%"}%
 <h2 ><nop>%TMPL:P{context="DBCachePluginEnabled" then="formname::dbcache" else="formname::standard"}%%TMPL:P{"changeform"}%</h2>
 <div class="foswikiFormSteps foswikiEditForm">
-<table class="foswikiLayoutTable">
+<table class="foswikiLayoutTable foswikiFormTable">

-- MichaelDaum - 23 Jun 2015

Thanks Michael. It was good that you were able to keep the TH approach but match formatting as in 1.1.9.

-- RiskReward - 23 Jun 2015

Commenting is disabled while not logged in