Item13352: EDITTABLE macro is ignored, Undefined ARRAY reference in Tables::Reader due to unbalanced verbatim tag in topic.

pencil
Priority: Urgent
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Extension
Component: EditRowPlugin, FoswikiTables
Branches: master
Reported By: MarkoKuder
Waiting For:
Last Change By: GeorgeClark
-- MarkoKuder - 06 Apr 2015

Could you provide some more feedback on exactly how you create the issue?

See http://trunk.foswiki.org/Sandbox/TestItem13352 where I've got both color and edittable macros.

-- GeorgeClark - 06 Apr 2015

Oops. Checkins here are unrelated, should have been applied to Item13357

-- GeorgeClark - 08 Apr 2015

Yes, I see that it is working in your sandbox. I have attached two sources of resulting pages on our installation, one with a working table (without color macro) and other not working. It seems that the main problems are with the color macros, not the table plugin. Some observations: - each color block seems to have a tag appended to it (without an opening one) - if the color block is after the table, it works ok (although the verbatim tag is still there) - any page that starts with a color block (without any other text before it) throws an internal error "Can't use an undefined value as an ARRAY reference" on our site, i have attached an error.log of this - your sandbox text editor seems more polished than our 1.1.9 version (raw text with an added toolbar). Is this a feature of 1.2.0? Perhaps we should try installing the beta?

-- MarkoKuder - 10 Apr 2015

Did you include the %ENDCOLOR% tag to close the span. % Red text %ENDCOLOR%

I agree that it shouldn't crash though, even with malformed html. However I removed the %ENDCOLOR% tag from the trunk.foswiki.org test site, and it doesn't crash there.

-- GeorgeClark - 10 Apr 2015

Ah ha... I had to download and compare the working and notworking html. There is an extraneous </verbatim> tag. My guess is that if you check your System/DefaultPreferences or SitePreferences topics, something has wrapped the verbatim tag onto the * Set ENDCOLOR tag. Edit the topics with the wkitext editor, don't use the Wysiwyg editor!

It should look like:

<verbatim>
...
      * Set WHITE = <span class='foswikiWhiteFG'>
      * Set ENDCOLOR = </span>
</verbatim>

Note that the closing verbatim tag should be on a separate line. I'm guessing that an edit with the WYSIWYG editor wrapped the line.

-- GeorgeClark - 10 Apr 2015

Confirmed. I added an extraneous /verbatim, and trunk now crashes. Setting to urgent.

-- GeorgeClark - 10 Apr 2015

Checked in a failing unit test.

-- GeorgeClark - 10 Apr 2015

This is now fixed in 1.1.9. Install TablesContrib version 1.02. Task set Waiting for Release, for the 1.2. release of Foswiki.

-- GeorgeClark - 13 Apr 2015
 

  • error.log: error when putting a color block at start of page

ItemTemplate edit

Summary EDITTABLE macro is ignored, Undefined ARRAY reference in Tables::Reader due to unbalanced verbatim tag in topic.
ReportedBy MarkoKuder
Codebase 1.1.9
SVN Range
AppliesTo Extension
Component EditRowPlugin, FoswikiTables
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:2d1a0eaae533 distro:1a156f3538fd TablesContrib:30cbaa2cbed5
TargetRelease major
ReleasedIn 2.0.0
CheckinsOnBranches master
trunkCheckins
masterCheckins distro:2d1a0eaae533 distro:1a156f3538fd TablesContrib:30cbaa2cbed5
ItemBranchCheckins
Release01x01Checkins
I Attachment Action Size Date Who Comment
error.loglog error.log manage 3 K 10 Apr 2015 - 16:45 MarkoKuder error when putting a color block at start of page
notworking.htmlhtml notworking.html manage 21 K 10 Apr 2015 - 16:32 MarkoKuder non working edittable with color macro
working.htmlhtml working.html manage 24 K 10 Apr 2015 - 16:31 MarkoKuder working table without color macros
Topic revision: r8 - 05 Jul 2015, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy