You are here: Foswiki>Tasks Web>Components>LdapContrib>Item12702 (22 Apr 2016, MichaelDaum)Edit Attach

Item12702: Re-using config during upgrade can cause error

Priority: Normal
Current State: No Action Required
Released In: n/a
Target Release:

Applies To: Extension
Component: LdapContrib
Branches:

Reported By: CrawfordCurrie
Waiting For:
Last Change By: MichaelDaum

    userBase => $Foswiki::cfg{Ldap}{UserBase}
      || $Foswiki::cfg{Ldap}{Base}
      || [],

and then on line 232:

  unless (ref($this->{userBase})) {
    push @{$this->{userBase}}, $this->{userBase};
  }

However Config.spec defines

# **STRING**
$Foswiki::cfg{Ldap}{Base} = 'dc=my,dc=domain,dc=com';

# **PERL**
# A list of trees where to search for users records. 
$Foswiki::cfg{Ldap}{UserBase} = ['ou=people,dc=my,dc=domain,dc=com'];

The mixing of the string type with the array type causes a crash if you define {Ldap}{Base} but not {Ldap}{UserBase} in LSC (as is the case when you upgrade from some earlier versions)

Not a huge problem, but needs fixing.

-- CrawfordCurrie - 20 Dec 2013

Closing due to lack of actions.

-- MichaelDaum - 22 Apr 2016

ItemTemplate edit

Summary	Re-using config during upgrade can cause error
ReportedBy	CrawfordCurrie
Codebase	1.1.9
SVN Range
AppliesTo	Extension
Component	LdapContrib
Priority	Normal
CurrentState	No Action Required
WaitingFor
Checkins
ReleasedIn	n/a
CheckinsOnBranches
trunkCheckins
masterCheckins
ItemBranchCheckins
Release02x01Checkins
Release02x00Checkins
Release01x01Checkins