You are here: Foswiki>Tasks Web>Component>JsonRpcContrib>Item12026 (23 Sep 2014, MichaelDaum)Edit Attach

Item12026: JsonRpcContrib: json2 not loaded in IE7

Priority: Normal
Current State: Closed
Released In: n/a
Target Release: n/a

Applies To: Extension
Component: JsonRpcContrib
Branches: trunk master

Reported By: JanKrueger
Waiting For:
Last Change By: MichaelDaum

The code in JQueryPlugin.pm tries to load json2.js in IE7, using an IE conditional comment. Unfortunately IE7 is rather picky about its syntax and simply ignores the whole thing in its current incarnation. This means that edit features (at the least; I haven't tested everything) are completely unusable in IE7.

Here's a diff to fix it.

diff --git a/lib/Foswiki/Contrib/JsonRpcContrib/JQueryPlugin.pm b/lib/Foswiki/Contrib/JsonRpcContrib/JQueryPlugin.pm
index 97f7dfa..df087a7 100644
--- a/lib/Foswiki/Contrib/JsonRpcContrib/JQueryPlugin.pm
+++ b/lib/Foswiki/Contrib/JsonRpcContrib/JQueryPlugin.pm
@@ -57,7 +57,7 @@ sub init {
   $this->SUPER::init();
 
   my $text =
-"<literal><!-- [if lte IE 7]>\n".
+"<literal><!--[if lte IE 7]>\n".
 $this->renderJS("json2.js").
 "<![endif]--></literal>";

-- JanKrueger - 02 Aug 2012

ItemTemplate edit

Summary	JsonRpcContrib: json2 not loaded in IE7
ReportedBy	JanKrueger
Codebase
SVN Range
AppliesTo	Extension
Component	JsonRpcContrib
Priority	Normal
CurrentState	Closed
WaitingFor
Checkins	JsonRpcContrib:ae337ac79759 JsonRpcContrib:e17fddd2a49d distro:af451e56082e distro:38b9e9cc6fbc
TargetRelease	n/a
ReleasedIn	n/a
CheckinsOnBranches	trunk master
trunkCheckins	JsonRpcContrib:ae337ac79759 JsonRpcContrib:e17fddd2a49d
masterCheckins	distro:af451e56082e distro:38b9e9cc6fbc
Release01x01Checkins