You are here: Foswiki>Tasks Web>Item11452 (11 Apr 2012, GeorgeClark)Edit Attach

Item11452: MetaCache robustness: remove from cache on `$topicObject->finish()`

Priority: Normal
Current State: Closed
Released In: 1.1.5
Target Release: patch

Applies To: Engine
Component:
Branches: Release01x01 trunk

Reported By: PaulHarvey
Waiting For: PaulHarvey
Last Change By: GeorgeClark

Presently, metacache can return a finished Foswiki::Meta obj if somebody somewhere has called $topicObject->finish().

This madness is/will be repaired in the store2 refactor (read-only topicObjects).

As most developers are naughty and generally don't ->finish() their objects in quite the sequence and circumstances (interactions with SEARCH) required to trigger this bug, nobody but me seems to have noticed.

-- PaulHarvey - 18 Jan 2012

Originally found while working on Item11431

-- PaulHarvey - 18 Jan 2012

Fn_SEARCH::test_metacache_madness was committed under Item11431, distro:7fa8ecad1d90 and distro:98f90cfd21a0

-- PaulHarvey - 19 Jan 2012

Fixed incorrect removeMeta return value on Release01x01

-- PaulHarvey - 19 Jan 2012

ItemTemplate edit

Summary	MetaCache robustness: remove from cache on `$topicObject->finish()`
ReportedBy	PaulHarvey
Codebase	1.1.4, 1.1.4 RC2, 1.1.4 RC1, 1.1.4 beta2, 1.1.4 beta1, trunk
SVN Range
AppliesTo	Engine
Component
Priority	Normal
CurrentState	Closed
WaitingFor	PaulHarvey
Checkins	distro:0e86c1336e3b distro:041aaa2871fe distro:e0f8d6e15f74
TargetRelease	patch
ReleasedIn	1.1.5
CheckinsOnBranches	Release01x01 trunk
trunkCheckins	distro:0e86c1336e3b
Release01x01Checkins	distro:041aaa2871fe distro:e0f8d6e15f74