You are here: Foswiki>Tasks Web>Item11193 (06 Nov 2018, MichaelDaum)Edit Attach

Item11193: typo in lib/Foswiki/PageCache.pm causing all (cached) pages to be delivered with a Last-Modified: header set to 01 Jan 1970:

Priority: Normal
Current State: Closed
Released In: 1.1.4
Target Release: patch

Applies To: Engine
Component: PageCache
Branches:

Reported By: FlorianSchlichting
Waiting For:
Last Change By: MichaelDaum

There's a typo in lib/Foswiki/PageCache.pm causing all (cached) pages to be delivered with a Last-Modified: header set to 01 Jan 1970:

-- a/lib/Foswiki/PageCache.pm
+++ b/lib/Foswiki/PageCache.pm
@@ -205,7 +205,7 @@ sub cachePage {
             $text = Compress::Zlib::memGzip($text);
         }
         $etag = $time;
-        $lastModified = Foswiki::Time::formatTime( $time, 'http', 'gmtime' );
+        $lastModified = Foswiki::Time::formatTime( $time, '$http', 'gmtime' );
     }
 
     my $headers   = $session->{response}->headers();

Please check the formatTime() definition at lib/Foswiki/Time.pm:250 and compare a similar use at lib/Foswiki.pm:840

-- FlorianSchlichting - 21 Oct 2011

ItemTemplate edit

Summary	typo in lib/Foswiki/PageCache.pm causing all (cached) pages to be delivered with a Last-Modified: header set to 01 Jan 1970:
ReportedBy	FlorianSchlichting
Codebase	1.1.3, trunk
SVN Range
AppliesTo	Engine
Component	PageCache
Priority	Normal
CurrentState	Closed
WaitingFor
Checkins	distro:303bbf100020 distro:0e4aa1e67818
TargetRelease	patch
ReleasedIn	1.1.4