You are here: Foswiki>Tasks Web>Item10837 (17 Dec 2011, GeorgeClark)Edit Attach

Item10837: Deprecated (before/after)AttachmentSaveHanders were actually deleted.

Priority: Urgent
Current State: Closed
Released In: 1.1.4
Target Release: patch

Applies To: Engine
Component: FoswikiPluginsAPI
Branches:

Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark

The beforeAttachmentSaveHandler and afterAttachmentSaveHandler were moved from the registrableHandler list to the deprecated list. They should have been copied not moved.

This breaks a number of plugins including AntiWikiSpamPlugin, BlackListPlugin, BatchUploadPlugin,

-- GeorgeClark - 05 Jun 2011

Why were they deprecated? Did we have an approved feature proposal for that?

-- KennethLavrsen - 05 Jun 2011

This was done in the early 1.1 days.

Item8749 - DeprecateAfterAttachmentSaveHandler

Looks like it was just a typo in the commit.

commit 3c8f0c4e93b5799ea6f601772119065d14797b6b
Author: MichaelDaum <MichaelDaum@0b4bb1d4-4e5a-0410-9cc4-b2b747904278>
Date:   Mon Mar 22 15:21:24 2010 +0000

    Item8437:Item8749:
    
       * fixed move/remane of attachments on the same topic
       * implemented before/afterUploadHandler
       * deprecated before/afterAttachmentSaveHandler
    
    
    
    git-svn-id: http://svn.foswiki.org/trunk@6850 0b4bb1d4-4e5a-0410-9cc4-b2b747904278

-- GeorgeClark - 06 Jun 2011

ItemTemplate edit

Summary	Deprecated (before/after)AttachmentSaveHanders were actually deleted.
ReportedBy	GeorgeClark
Codebase	1.1.3, 1.1.3 RC1, 1.1.3 beta1, 1.1.2, 1.1.1, 1.1.0, 1.1.0 beta1, trunk
SVN Range
AppliesTo	Engine
Component	FoswikiPluginsAPI
Priority	Urgent
CurrentState	Closed
WaitingFor
Checkins	distro:568cb6414dd5 distro:86261bb1e219
TargetRelease	patch
ReleasedIn	1.1.4